Multithreading support & overhaul of scope handling #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d out stuff for now)
…threaded scoping now!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely changes how scope state is handled!
Creating a scope now returns it and needs to be passed in again on
end_scope. Both these functions now only take a non-mut reference toGpuProfiler, allowing it to be used across threads or simply interleaved with several encoders.This also means that nesting is done now explicitly, which means that the profiling macro no longer made sense.
Instead,
Scope/OwningScopeare now proper first class citizens and are exposed directly onGpuProfiler