fix tests, doctests and wasm build #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidster
commented
Feb 6, 2024
| @@ -18,7 +18,7 @@ fn invalid_pending_frame_count() { | |||
|
|
|||
| #[test] | |||
| fn end_frame_unclosed_query() { | |||
| let (_, device, _) = create_device(wgpu::Features::TIMESTAMP_QUERY).unwrap(); | |||
| let (_, device, _queue) = create_device(wgpu::Features::TIMESTAMP_QUERY).unwrap(); | |||
There was a problem hiding this comment.
Believe it or not, the test was panicking without this change, since the queue was getting dropped before calling Device::create_command_encoder. I added a test to wgpu to check for this:
There was a problem hiding this comment.
huh interesting. wonder why I didn't hit this before. Thanks for following up over on wgpu!
Wumpf
approved these changes
Feb 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #61
Let me know if you'd like me to separate the test fixes from the wasm fix, it's no issue.