-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to wgpu 22.1.0 #75
Conversation
Hmm, that's an interesting build failure. |
This failure is due to gfx-rs/wgpu#5988 |
a133cd6
to
dba7397
Compare
Thanks for opening this! Looks like we'll have to wait for Since there's already so many people knocking to move forward, I'd say we create an issue about this here to track it and remove tracy and then readd it once there's a wgpu patch release out at which point yet-another wgpu-profiler version releases |
Don't remove Tracy support! The whole point of this crate is profiling. I need this upgrade so I can look for known performance bugs using a later WGPU. If I report performance bugs for any WGPU other than the very latest, the maintainers want the problem reproduced on the "current version". |
I think we should do a patch release pretty soon, there's a few things that need to be patched |
ahh these annoying wgpu maintainers 😅 |
Sounds good to me, happy to wait a bit. |
3ef0e33
to
ddd7062
Compare
Updated for 22.1.0! I didn't update all of the stuff ... so maybe that should happen after this and before the release. Just an update to |
Needs a version bump so it can be pushed to crates.io. |
Assuming this is about the crate version and not I should add a CHANGELOG entry though to this commit to make that easier. |
This changes a lifetime for scoped render pipelines to match a similar change for `begin_render_pass` in wgpu itself.
ddd7062
to
7f27bd3
Compare
done so directly on main now and published a new version to crates.io |
Thank you! |
Should that release have a corresponding tag as well? |
ah yes, forgot about that, thx! |
This changes a lifetime for scoped render pipelines to match a similar change for
begin_render_pass
in wgpu itself.