Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolve_queries calls per frame causing invalid buffer copy operations #83

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

Wumpf
Copy link
Owner

@Wumpf Wumpf commented Sep 21, 2024

The previous fix #80 had a mistake in it.

Confirmed it by extending the regression test to catch this and successfully tested against linebender/vello#687
via

[patch.crates-io]
wgpu-profiler = { git = "https://github.com/wumpf/wgpu-profiler", rev = "72de1a4cc1abe685e26cab56ac664b9c1577e0ff" }

Fixes

@Wumpf Wumpf linked an issue Sep 21, 2024 that may be closed by this pull request
@Wumpf Wumpf merged commit b42530d into main Sep 21, 2024
1 check passed
@Wumpf Wumpf deleted the andreas/fix-incorrect-copy branch September 21, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy Error: Start is offset by 256 in Vello
1 participant