Update to wgpu 23.0.0 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The demo is crashing on macOS with a validation error that the surface hasn't been configured. I'm still looking into that. |
|
looks like the demo only ever does configure on resize. how did this ever work..? |
|
Well, I think |
|
If the demo was already not implemented correctly, is it worth merging this as-is (it seems to have been validated by the author of #89), and moving the issue with the demo to its own issue? |
Not doing this led to panics with wgpu 23.
|
@Wumpf Looks like just a single line fix to the demo was enough. Hopefully this is good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.