GH-638 get id of condition for apply_billboard

classes/bo_availability/bo_condition.php

@@ -155,4 +155,11 @@ public function render_button(booking_option_settings $settings,
      * @return array
      */
     public function return_sql(): array;
+
+    /**
+     * Returns the id of the condition.
+     *
+     * @return int
+     */
+    public function get_id(): int;
 }

classes/bo_availability/bo_info.php

@@ -902,20 +902,24 @@ public static function render_button(
      * @return void
      *
      */
-    private static function overwrite_warnings_with_billboard(booking_option_settings $settings, string $role, string &$label) {
-        // TODO maybe implement settings for plugin if billboard is activated.
-        if ($role == 'button') {
-            return;
+    public static function apply_billboard(bo_condition $condition, booking_option_settings $settings): string {
+        if (empty(get_config('booking', 'conditionsoverwritingbillboard'))) {
+            return '';
+        }
+        if (in_array($condition->get_id(), MOD_BOOKING_CONDTIONS_EXCLUDED_FROM_OVERWRITING_DESCRIPTION_BILLBOARD)) {
+            return '';
         }
+
         // Fetch settings of instance to see if alert needs to be overwritten.
         $instance = singleton_service::get_instance_of_booking_by_bookingid($settings->bookingid);
+        if (empty($instance->settings->json)) {
+            return '';
+        }
         $jsondata = json_decode($instance->settings->json);
         if (empty($jsondata->billboardtext)) {
-            return;
+            return '';
         }
-        $formattext = format_text($jsondata->billboardtext);
-
-        $label = $formattext;
+        return format_text($jsondata->billboardtext);
     }
 
     /**

classes/bo_availability/conditions/allowedtobookininstance.php

@@ -64,6 +64,16 @@ public function __construct(?int $id = null) {
         }
     }
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/alreadybooked.php

@@ -49,6 +49,16 @@ class alreadybooked implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_ALREADYBOOKED;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/alreadyreserved.php

@@ -46,6 +46,16 @@ class alreadyreserved implements bo_condition {
     /** @var int $id default conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_ALREADYRESERVED;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/askforconfirmation.php

@@ -53,6 +53,16 @@ class askforconfirmation implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_ASKFORCONFIRMATION;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/booking_time.php

@@ -55,6 +55,16 @@ class booking_time implements bo_condition {
     /** @var bool $overridable Indicates if the condition can be overriden. */
     public $overridable = true;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/bookingpolicy.php

@@ -51,6 +51,16 @@ class bookingpolicy implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_BOOKINGPOLICY;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/bookitbutton.php

@@ -57,6 +57,16 @@ class bookitbutton implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_BOOKITBUTTON;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/bookondetail.php

@@ -50,6 +50,16 @@ class bookondetail implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_BOOKONDETAIL;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/bookwithcredits.php

@@ -57,6 +57,16 @@ class bookwithcredits implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_BOOKWITHCREDITS;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/bookwithsubscription.php

@@ -57,6 +57,16 @@ class bookwithsubscription implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_BOOKWITHSUBSCRIPTION;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/campaign_blockbooking.php

@@ -54,6 +54,16 @@ class campaign_blockbooking implements bo_condition {
     /** @var string $blockinglabel String to display when blocking. */
     private $blockinglabel = '';
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/cancelmyself.php

@@ -53,6 +53,16 @@ class cancelmyself implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_CANCELMYSELF;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/capbookingchoose.php

@@ -49,6 +49,16 @@ class capbookingchoose implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_CAPBOOKINGCHOOSE;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/confirmation.php

@@ -52,6 +52,16 @@ class confirmation implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_CONFIRMATION;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/confirmbookit.php

@@ -50,6 +50,16 @@ class confirmbookit implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_CONFIRMBOOKIT;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/confirmbookwithcredits.php

@@ -50,6 +50,16 @@ class confirmbookwithcredits implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_CONFIRMBOOKWITHCREDITS;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/confirmbookwithsubscription.php

@@ -50,6 +50,16 @@ class confirmbookwithsubscription implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_CONFIRMBOOKWITHSUBSCRIPTION;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/confirmcancel.php

@@ -51,6 +51,16 @@ class confirmcancel implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_CONFIRMCANCEL;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/customform.php

@@ -72,6 +72,16 @@ public function __construct(?int $id = null) {
         }
     }
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool

classes/bo_availability/conditions/electivebookitbutton.php

@@ -57,6 +57,16 @@ class electivebookitbutton implements bo_condition {
     /** @var int $id Standard Conditions have hardcoded ids. */
     public $id = MOD_BOOKING_BO_COND_ELECTIVEBOOKITBUTTON;
 
+    /**
+     * Get the condition id.
+     *
+     * @return int
+     *
+     */
+    public function get_id(): int {
+        return $this->id;
+    }
+
     /**
      * Needed to see if class can take JSON.
      * @return bool