Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coursecalendarurl shortcode generates text url not a html link #754

Closed
danbuntu opened this issue Dec 9, 2024 · 2 comments
Closed

coursecalendarurl shortcode generates text url not a html link #754

danbuntu opened this issue Dec 9, 2024 · 2 comments
Assignees

Comments

@danbuntu
Copy link

danbuntu commented Dec 9, 2024

Is your feature request related to a problem? Please describe.
When including the shortcode [coursecalendarurl] the url is rendered as text. Adding this is a link within the email ie.

<a href="[coursecalendarurl ]">Link to calender</a>

Fails to render the link correctly as a clickable link. Add the shortcode on it's own and it just renders as text,

Describe the solution you'd like
I think that the short code should render as a clickable link

I suggest the following change to classes/placeholders/placeholders/coursecalenderurl.php line 84

      $value = '<a href="' . $bu->booking_generate_calendar_subscription_link($user, 'courses') . '">' .
                    get_string('linktocalenderurltext', 'mod_booking') .
                '</a>';
@danbuntu
Copy link
Author

This is essentially the same bug as #767 - i've checked and it appears there are onyl two occurances of this bug

@eynimeni
Copy link
Contributor

@danbuntu thanks for bringing this to our attention. will be deployed in one of the next versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants