Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

booking option link in emails is rendered as text #767

Closed
danbuntu opened this issue Dec 13, 2024 · 2 comments
Closed

booking option link in emails is rendered as text #767

danbuntu opened this issue Dec 13, 2024 · 2 comments
Assignees

Comments

@danbuntu
Copy link

Describe the bug
The goto booking option link in {bookingdetails} is rendered as url rather than nice text

https://domain/mod/booking/optionview.php?optionid=199&cmid=470&userid=197&returnto=url&returnurl
not
Go to bookiing link

This is not accessible and just plain ugaly

Versions uses
Moodle version: 4.13
Boooking version: latest stable

To Reproduce
Steps to reproduce the behavior:

  1. Send an email that contains the {bookingdetails} shortcode
  2. Read the email using a screenreader
  3. Cry as it trys to read out the url

Expected behavior
Link rendered as a nice link

I suggest classes\output\bookingoption_description line 521 changes to:

        $this->booknowbutton = get_string('gotobookingoption', 'booking') . ': ' .
                    '<a href = "' . $moodleurl . '" target = "_blank">' .
                        get_string('gotobookingoptionlink', 'booking') .
                    '</a>';

and lang string is added

@danbuntu
Copy link
Author

This is essentially the same bug as #754 - i've checked and it appears there are onyl two occurances of this bug

@eynimeni
Copy link
Contributor

@danbuntu thank you for your recommendation! in the next version of the plugin, the clickable text to be displayed can be overwritten in the string "gotobookingoptionlink"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants