Fix views index bug

classes/datalynx.php

@@ -1533,7 +1533,7 @@ public function get_views_by_type($type, $forceget = false) {
      * @return array of view objects indexed by view id or false if no views are found
      */
     public function get_views(array $exclude = [], bool $forceget = false, string $sort = '') {
-        if (!empty($this->get_view_records($forceget, $sort))) {
+        if (empty($this->get_view_records($forceget, $sort))) {
             return false;
         }
 
@@ -1691,7 +1691,7 @@ public function process_views($action, $vids, $confirmed = false) {
 
         if ($vids) { // Some views are specified for action.
             $views = array();
-            $viewobjs = $this->get_views(false, true);
+            $viewobjs = $this->get_views([], true);
             foreach (explode(',', $vids) as $vid) {
                 if (!empty($viewobjs[$vid])) {
                     $views[$vid] = $viewobjs[$vid];

version.php

@@ -24,7 +24,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 $plugin->component = 'mod_datalynx';
-$plugin->version = 2024012501;
+$plugin->version = 2024012502;
 $plugin->release = 'v3.3-DataIntelligence'; // Data words like data science, data mining.
 $plugin->requires = 2022112800;
 $plugin->maturity = MATURITY_STABLE;

view/index.php

@@ -105,7 +105,7 @@
 
 // Any notifications?
 $dl->notifications['bad']['defaultview'] = '';
-$views = $dl->get_views(null, true,
+$views = $dl->get_views([], true,
         flexible_table::get_sort_for_table('datalynxviewsindex' . $dl->id()));
 if (!$views) {
     $dl->notifications['bad']['getstartedviews'] = get_string('viewnoneindatalynx', 'datalynx'); // Nothing.