Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution for twosum #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tushar-nitave
Copy link

@tushar-nitave tushar-nitave commented Oct 18, 2019

@MrHeer MrHeer requested a review from a team October 18, 2019 23:46
@MrHeer MrHeer added the 💻 WIP Work in progress label Oct 18, 2019
Copy link
Member

@MrHeer MrHeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, Thank you for your PR!!
I think there are several problems as follows:

  1. You should format code with clang-format.
  2. Solve it with One-pass Hash Table will be better.
  3. Fix commit title and PR title to fix Semantic Pull Request check.

@@ -0,0 +1,43 @@
#include <iostream>
#include <vector>
#include <unordered_map>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used?

# Reverse Integer

LeetCode [source](https://leetcode.com/problems/two-sum/)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a Solution with Intuition, Algorithm and Complexity Analysis like README.md.

src/TwoSum/README.md Show resolved Hide resolved
vector<int> result = s.twoSum(nums, target);
cout<<result[0]<<" "<<result[1];
return 0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last line should have a newline character.

@MrHeer
Copy link
Member

MrHeer commented Dec 4, 2019

PING @tushar-nitave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants