Skip to content
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.

implement web3 #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

implement web3 #56

wants to merge 1 commit into from

Conversation

nionis
Copy link
Contributor

@nionis nionis commented Aug 24, 2018

Right now we have been using web3-utils and web3-eth-abi which are packages shipped with web3.

To do:

  • removed web3-utils and web3-eth-abi

versions are now locked together because we use web3 only

  • update dockerfile
  • switch to websocket provider
  • update ingestion to use web3
  • expose our web3 provider to reducers
  • use web3 provided typings when possible (?)

edit 1: update todo
edit 2: update todo

@nionis
Copy link
Contributor Author

nionis commented Aug 24, 2018

question marks means whether the idea is good or not

@shrugs
Copy link
Member

shrugs commented Aug 26, 2018

Let's update the Web3Api ingest to use web3, yeah. It should be possible to use web3.provider.sendAsync to do the traceTransaction call.

I think it's also a good idea to switch to websocket providers (let's just switch entirely and not support HTTP providers at all, imo).

Does web3-1.0 have real typings now? If so, they should just work but we may need a @types/web3 devDependency.

I'm not sure what the api surface we want for reducers should look like; what were you thinking? It might be fine to just expose our web3 provider as a global so that reducers can bundle their own web3 (like how metamask and friends don't inject web3.js anymore, they just inject the node url.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants