Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce levelization in libxrpl with CMake #5111

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Rename module isolation directory

4e11039
Select commit
Loading
Failed to load commit list.
Open

Enforce levelization in libxrpl with CMake #5111

Rename module isolation directory
4e11039
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 20, 2024 in 0s

75.4% (target 60.0%)

View this Pull Request on Codecov

75.4% (target 60.0%)

Details

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.4%. Comparing base (b6391fe) to head (4e11039).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
include/xrpl/basics/SHAMapHash.h 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5111     +/-   ##
=========================================
- Coverage     76.2%   75.4%   -0.8%     
=========================================
  Files          760     666     -94     
  Lines        61550   58420   -3130     
  Branches      8123    7982    -141     
=========================================
- Hits         46884   44061   -2823     
+ Misses       14666   14359    -307     
Files with missing lines Coverage Δ
include/xrpl/basics/partitioned_unordered_map.h 99.1% <100.0%> (+<0.1%) ⬆️
include/xrpl/protocol/AmountConversions.h 87.5% <ø> (ø)
include/xrpl/protocol/FeeUnits.h 90.1% <ø> (ø)
include/xrpl/protocol/Fees.h 100.0% <ø> (ø)
include/xrpl/protocol/LedgerHeader.h 100.0% <ø> (ø)
include/xrpl/protocol/PayChan.h 100.0% <ø> (ø)
src/libxrpl/basics/Number.cpp 99.7% <ø> (-<0.1%) ⬇️
src/xrpld/app/misc/LoadFeeTrack.h 87.8% <ø> (ø)
src/xrpld/app/misc/detail/LoadFeeTrack.cpp 89.5% <ø> (ø)
src/xrpld/app/paths/Flow.cpp 96.2% <ø> (ø)
... and 19 more

... and 99 files with indirect coverage changes

Impacted file tree graph