Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add more test cases for Base58 parser #5174

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Merge remote-tracking branch 'upstream/develop' into pr/base58-tests

a7d0dd3
Select commit
Loading
Failed to load commit list.
Open

test: Add more test cases for Base58 parser #5174

Merge remote-tracking branch 'upstream/develop' into pr/base58-tests
a7d0dd3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2024 in 1s

77.9% (target 60.0%)

View this Pull Request on Codecov

77.9% (target 60.0%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (838978b) to head (a7d0dd3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5174     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          782     782             
  Lines        66621   66619      -2     
  Branches      8161    8136     -25     
=========================================
- Hits         51902   51899      -3     
- Misses       14719   14720      +1     
Files with missing lines Coverage Δ
include/xrpl/protocol/detail/b58_utils.h 95.5% <ø> (-0.1%) ⬇️

... and 4 files with indirect coverage changes

Impacted file tree graph