Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT Wip/5171 #5180

Closed
wants to merge 12 commits into from
Closed

DRAFT Wip/5171 #5180

wants to merge 12 commits into from

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Nov 5, 2024

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

* Follow up to XRPLF#5120 (23991c9), which added a retry for submit commands.
  It improved MacOS test reliability, but other tests are failing now.
* Retry all failed RPC connections / commands in unit tests.
* upstream/develop:
  Add hubs.xrpkuwait.com to bootstrap (5169)
* upstream/develop:
  Add AMMClawback Transaction (XLS-0073d) (5142)
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (838978b) to head (7f74c46).

Files with missing lines Patch % Lines
include/xrpl/server/detail/Door.h 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5180     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.1%     
=========================================
  Files          782     782             
  Lines        66621   66619      -2     
  Branches      8161    8161             
=========================================
- Hits         51902   51863     -39     
- Misses       14719   14756     +37     
Files with missing lines Coverage Δ
include/xrpl/server/detail/Door.h 79.3% <0.0%> (ø)

... and 8 files with indirect coverage changes

Impacted file tree graph

@ximinez ximinez force-pushed the wip/5171 branch 3 times, most recently from 7235d14 to e5a1123 Compare November 8, 2024 14:42
* upstream/develop:
  Set version to 2.3.0-rc1
  Replace Uint192 with Hash192 in server_definitions response (5177)
  Fix potential deadlock (5124)
  Introduce Credentials support (XLS-70d): (5103)
  Fix token comparison in Payment (5172)
  Add fixAMMv1_2 amendment (5176)
@ximinez ximinez force-pushed the wip/5171 branch 3 times, most recently from 0e3047e to 234a38a Compare November 12, 2024 17:19
* Rename the RpcCallback type, and the default variables of that type
* Move the "default callback" out of the retry logic, and into the variable
  definition.
* Get rid of the checkTER parameter to parseResult.
* upstream/develop:
  fix: include `index` in `server_definitions` RPC (5190)
  Fix ledger_entry crash on invalid credentials request (5189)
@ximinez
Copy link
Collaborator Author

ximinez commented Nov 13, 2024

Rolled into #5171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant