-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT Wip/5171 #5180
Closed
Closed
DRAFT Wip/5171 #5180
+332
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Follow up to XRPLF#5120 (23991c9), which added a retry for submit commands. It improved MacOS test reliability, but other tests are failing now. * Retry all failed RPC connections / commands in unit tests.
* upstream/develop: Add hubs.xrpkuwait.com to bootstrap (5169)
* upstream/develop: Add AMMClawback Transaction (XLS-0073d) (5142)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5180 +/- ##
=========================================
- Coverage 77.9% 77.9% -0.1%
=========================================
Files 782 782
Lines 66621 66619 -2
Branches 8161 8161
=========================================
- Hits 51902 51863 -39
- Misses 14719 14756 +37
|
* upstream/develop: Fix unity build (5179)
ximinez
force-pushed
the
wip/5171
branch
3 times, most recently
from
November 8, 2024 14:42
7235d14
to
e5a1123
Compare
* upstream/develop: Set version to 2.3.0-rc1 Replace Uint192 with Hash192 in server_definitions response (5177) Fix potential deadlock (5124) Introduce Credentials support (XLS-70d): (5103) Fix token comparison in Payment (5172) Add fixAMMv1_2 amendment (5176)
ximinez
force-pushed
the
wip/5171
branch
3 times, most recently
from
November 12, 2024 17:19
0e3047e
to
234a38a
Compare
* Rename the RpcCallback type, and the default variables of that type * Move the "default callback" out of the retry logic, and into the variable definition. * Get rid of the checkTER parameter to parseResult.
* upstream/develop: fix: include `index` in `server_definitions` RPC (5190) Fix ledger_entry crash on invalid credentials request (5189)
ximinez
force-pushed
the
wip/5171
branch
2 times, most recently
from
November 13, 2024 21:39
bfc4ec4
to
77b4316
Compare
2 tasks
* upstream/develop: Set version to 2.3.0-rc2
* Add a lot more retries across test network operations. * Add some network error logging details.
Rolled into #5171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)