Fix: Update wallet_propose method to use ED25519 as the default algorithm #5186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR aims to bring consistency between client library behavior and the rippled CLI's
wallet_propose
RPC. This PR needs to be viewed in conjunction with XRPLF/xrpl-py#770, XRPLF/xrpl-dev-portal#2844. The client libraries useed25519
as the default algorithm forWallet
-related methods, unlike rippled CLI which usessecp256k1
algorithm.Note:
keyPairForSignature
method still usessecp256k1
as the default cryptographic signing algorithm. I have not made any changes such internal methods.Context of Change
Since this is a breaking-change, I expect that I need to document this change somewhere in a CHANGELOG. But I'm not sure of the exact filename.
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)I don't expect any impact on the performance of the
wallet_propose
RPC.ed25519
algorithm is expected to be more efficient thansecp256k1
.