Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure typing works with Python 3.8 #167

Closed
wants to merge 1 commit into from
Closed

fix: ensure typing works with Python 3.8 #167

wants to merge 1 commit into from

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Oct 11, 2023

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Test Plan

@mvadari
Copy link
Collaborator Author

mvadari commented Oct 25, 2023

Added to #153

@mvadari mvadari closed this Oct 25, 2023
@mvadari mvadari deleted the fix-typing branch October 25, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mvadari