Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DID Docs #2306

Merged
merged 3 commits into from
Jan 10, 2024
Merged

DID Docs #2306

merged 3 commits into from
Jan 10, 2024

Conversation

oeggert
Copy link
Collaborator

@oeggert oeggert commented Dec 16, 2023 •
edited
Loading

@DennisDawson

I opened a new DID docs branch from a clean master to avoid merge conflicts introduced with all the recent changes.

Resolved your issues from #2273 so I mainly just need a quick lookover and approval.

@oeggert oeggert mentioned this pull request Dec 16, 2023
Closed
2 tasks
@github-actions GitHub Actions
Copy link

Link check report. 587620 links checked.
4 broken links found:
File: out/ja/diddelete.html Link: known-amendments.html#did
File: out/ja/didset.html Link: known-amendments.html#did
File: out/ja/did.html Link: known-amendments.html#did
File: out/ja/decentralized-identifiers.html Link: known-amendments.html#did

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/did-docs/

Style Report

1 similar comment
@github-actions GitHub Actions
Copy link

Link check report. 587620 links checked.
4 broken links found:
File: out/ja/diddelete.html Link: known-amendments.html#did
File: out/ja/didset.html Link: known-amendments.html#did
File: out/ja/did.html Link: known-amendments.html#did
File: out/ja/decentralized-identifiers.html Link: known-amendments.html#did

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/did-docs/

Style Report

@tequdev tequdev added the needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site label Dec 16, 2023
@amarantha-k amarantha-k self-requested a review December 18, 2023 21:41
mDuo13
mDuo13 requested changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a couple details of the amendment need to be updated/corrected, but everything else looks great!

content/concepts/accounts/decentralized-identifiers.md Outdated Show resolved Hide resolved
content/resources/known-amendments.md Outdated Show resolved Hide resolved
content/resources/known-amendments.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Link check report. 587593 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/did-docs/

Style Report

@oeggert oeggert requested a review from mDuo13 January 10, 2024 00:14
@github-actions GitHub Actions
Copy link

Link check report. 628786 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/did-docs/

Style Report

@oeggert oeggert merged commit 8a15e2e into master Jan 10, 2024
3 of 4 checks passed
@oeggert oeggert deleted the did-docs branch January 10, 2024 01:39
@tequdev tequdev removed the needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mDuo13 mDuo13 mDuo13 approved these changes

@DennisDawson DennisDawson Awaiting requested review from DennisDawson

@amarantha-k amarantha-k Awaiting requested review from amarantha-k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oeggert @mDuo13 @tequdev