Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TypeScript AMM sample code #2307

Merged
merged 4 commits into from
Jan 3, 2024
Merged

add TypeScript AMM sample code #2307

merged 4 commits into from
Jan 3, 2024

Conversation

mashharuki
Copy link
Contributor

Hey!!
I participated in the DeFi Hackathon in Japan in December.

I had a very hard time getting the AMM functionality to work at that time and developed sample code.

This sample code contains code that allows you to try out a full range of AMM-related functions such as DepositAMM, WithdrawAMM, and Swap, in addition to CreateAMM.

I would like to contribute the sample code I created to make it easier for developers to use the AMM feature of XRPL in the future.

Please check it.

[Hackathon Summary]
https://lu.ma/xrpl-hack

[Product created in the hackathon]
https://github.com/mashharuki/DCCEX

@mashharuki mashharuki marked this pull request as ready for review December 17, 2023 10:53
@oeggert oeggert self-requested a review December 18, 2023 21:41
@mDuo13
Copy link
Collaborator

mDuo13 commented Dec 18, 2023

At a quick glance, the code looks nice! I would like to try running the code, but I don't have much experience with TypeScript. Isn't there typically a package.json or similar file to list dependencies? If so, can you add a simple one to this PR?

Also, a note to other reviewers: We don't have an icon for TypeScript yet, so I think our code samples page will report a broken link unless we add one along with this PR and modify template/page-code-samples.html.jinja to use it (like e9d17c9 )

@mDuo13 mDuo13 changed the title add fully AMM sample codes add TypeScript AMM sample code Dec 18, 2023
@mashharuki
Copy link
Contributor Author

mashharuki commented Dec 19, 2023

@mDuo13 Thank you for checking!

Of course!!

package.json is here!

https://github.com/mashharuki/DCCEX/tree/main/pkgs/scripts

↑ There are other config files in this folder

@tequdev
Copy link
Contributor

tequdev commented Dec 28, 2023

@mashharuki

It is preferred that package.json and tsconfig.json be included in content/_code-samples/create-amm/ts.
Sample code must be completed in only content/_code-samples/create-amm/ts.

@mashharuki
Copy link
Contributor Author

@tequdev ok! I will add package.json & other config files!!

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
ts-node 10.9.2 filesystem +17 34.1 MB blakeembrey
dotenv 16.3.1 environment +0 71.6 kB motdotla
typescript 5.3.3 filesystem +0 32 MB typescript-bot

@mashharuki
Copy link
Contributor Author

mashharuki commented Dec 28, 2023

@mDuo13 @Fuk2828 @tequdev I added package.json & .env.example & tsconfig.json files in this PR! Please check it!

@mDuo13 mDuo13 merged commit 2981e86 into XRPLF:master Jan 3, 2024
2 checks passed
@mashharuki
Copy link
Contributor Author

Thank you everyone!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants