Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JA] fix request, response #2324

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

tequdev
Copy link
Contributor

@tequdev tequdev commented Jan 5, 2024

  • 要求 -> リクエスト
  • 応答 -> レスポンス

@tequdev tequdev requested a review from mDuo13 January 5, 2024 10:09
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea to use リクエスト in the context of the APIs, but these changes include quite a few cases that don't refer to the API. In those cases, I think 要求 still seems more appropriate. I could be out of date with how contemporary Japanese is used, though, so I'm willing to change my mind on that.

I've tagged several examples of the cases where I think it makes sense to change it back, but not all of them since there are a lot of pages changed.

@tequdev tequdev requested a review from mDuo13 January 10, 2024 04:06
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the changes, looks good. 👍

@mDuo13 mDuo13 merged commit 45ab81c into XRPLF:master Jan 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants