Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up the example default delete to 30,000 #2334

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

shortthefomo
Copy link
Contributor

up the example default delete to 30,000 as lower values have shown issues in production

Copy link
Contributor

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, with advisory_delete=1, online deletion runs only when prompted with can_delete.

@shortthefomo
Copy link
Contributor Author

shortthefomo commented Jan 12, 2024

Note, with advisory_delete=1, online deletion runs only when prompted with can_delete.

Correct however most validators will not be keeping history and use the automated process to purge records. The delete seems to be using more resources of the disk than before, pushing this value out simply makes the delete not run very often as the default suggested here it runs every few min.

@mDuo13 mDuo13 merged commit 5d9d303 into XRPLF:master Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants