Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First round of API v2 updates. #2340

Merged
merged 2 commits into from
Jan 23, 2024
Merged

First round of API v2 updates. #2340

merged 2 commits into from
Jan 23, 2024

Conversation

oeggert
Copy link
Collaborator

@oeggert oeggert commented Jan 12, 2024

This PR doesn't include updates to API v2 responses in affected methods.

@oeggert oeggert requested a review from mDuo13 January 12, 2024 03:37
Copy link

Link check report. 628916 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/api-v2-updates/

Style Report

@tequdev tequdev added the needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site label Jan 12, 2024
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, although I think the approach of using <br> in tables won't port nicely to Redocly so we'll have to try something else. (I suppose we could implement some kind of Markdoc component to insert a line break, or maybe use an existing component like {% tabs %} to do something fancier.

@oeggert oeggert requested a review from mDuo13 January 19, 2024 21:45
Copy link

Link check report. 631143 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/api-v2-updates/

Style Report

@mDuo13 mDuo13 merged commit 4e0efe2 into master Jan 23, 2024
3 of 4 checks passed
@mDuo13 mDuo13 deleted the api-v2-updates branch January 23, 2024 01:52
@tequdev tequdev removed the needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site label May 22, 2024
tequdev added a commit to tequdev/xrpl-dev-portal that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants