Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fields to NFTokenMint #2711

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add fields to NFTokenMint #2711

wants to merge 3 commits into from
+7 −5

Conversation

DennisDawson
Copy link
Contributor

@DennisDawson DennisDawson self-assigned this Aug 8, 2024
tequdev
tequdev requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@tequdev tequdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to mention that it is only available after activate the NFTokenMintOffer Amendment.

And could you also add to the Japanese page?
I don't mind if it remain in English.

@DennisDawson DennisDawson marked this pull request as draft August 9, 2024 20:10
@DennisDawson
Copy link
Contributor Author

Converting this to draft - this will not be pulled until the feature is live on Mainnet.

@DennisDawson
Copy link
Contributor Author

Per tequdev request, copied the English version into the Japanese internationalization directory.

@tequdev
Copy link
Contributor

tequdev commented Aug 19, 2024

It was intended to add only three fields in English to the end of the table.

@tequdev tequdev self-requested a review October 21, 2024 03:41
@Topher68chris
Copy link

Got you

@tequdev tequdev added the needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Topher68chris Topher68chris Topher68chris approved these changes

@tequdev tequdev tequdev approved these changes

Assignees

@DennisDawson DennisDawson

Labels
needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DennisDawson @tequdev @Topher68chris