fix: remove Python 3.7 support to fix dependency installation and use…

… 3.8 as new default (#737) * remove Python 3.7 support to fix dependency installation and use 3.8 as new default
XRPLF · Aug 15, 2024 · 17aad31 · 17aad31
1 parent cd0a0a7
commit 17aad31
Show file tree

Hide file tree

Showing 9 changed files with 388 additions and 407 deletions.
diff --git a/.github/workflows/integration_test.yml b/.github/workflows/integration_test.yml
@@ -17,7 +17,7 @@ jobs:
     timeout-minutes: 30
     strategy:
       matrix:
-        python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
 
     steps:
       - name: Checkout code

diff --git a/.github/workflows/snippet_test.yml b/.github/workflows/snippet_test.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
 
     steps:
       - name: Checkout code

diff --git a/.github/workflows/unit_test.yml b/.github/workflows/unit_test.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
 
     env:
-      PYTHON_VERSION: "3.7"
+      PYTHON_VERSION: "3.8"
 
     steps:
       - name: Checkout code
@@ -60,7 +60,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
 
     steps:
       - name: Checkout code

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [[Unreleased]]
 
+### BREAKING CHANGE:
+- Remove Python 3.7 support to fix dependency installation and use 3.8 as new default.
+
 ## [3.0.0] - 2024-07-16
 
 ### BREAKING CHANGE

diff --git a/README.md b/README.md
@@ -64,7 +64,7 @@ The `xrpl-py` library is available on [PyPI](https://pypi.org/). Install with `p
 pip3 install xrpl-py
 ```
 
-The library supports [Python 3.7](https://www.python.org/downloads/) and later.
+The library supports [Python 3.8](https://www.python.org/downloads/) and later.
 
 [![Supported Versions](https://img.shields.io/pypi/pyversions/xrpl-py.svg)](https://pypi.org/project/xrpl-py)
 

diff --git a/docs/index.rst b/docs/index.rst
@@ -15,7 +15,7 @@ See the `project README <https://github.com/XRPLF/xrpl-py/blob/main/README.md>`_
 
 Install
 --------------
-First, ensure that you have `Python 3.7 <https://www.python.org/downloads/>`_ or later.
+First, ensure that you have `Python 3.8 <https://www.python.org/downloads/>`_ or later.
 
 Then, download the package via ``pip``:
 

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -30,7 +30,7 @@ packages = [
 ]
 
 [tool.poetry.dependencies]
-python = "^3.7"
+python = "^3.8"
 base58 = "^2.1.0"
 ECPy = "^1.2.5"
 typing-extensions = "^4.2.0"

diff --git a/xrpl/models/base_model.py b/xrpl/models/base_model.py
@@ -177,7 +177,7 @@ def _from_dict_single_param(
 
         # no more collections (no params expect a Dict)
 
-        if param_type is Any:
+        if param_type is Any:  # type: ignore
             # param_type is Any (e.g. will accept anything)
             return param_value