Merge branch '3.0' into feature/https-proxy-agent-7

XRPLF · Jul 18, 2023 · 0901f1d · 0901f1d
2 parents d5d2cae + cf8b48b
commit 0901f1d
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 24 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -63,7 +63,7 @@
     "ts-jest": "^29.0.3",
     "ts-loader": "^9.2.5",
     "ts-node": "^10.2.1",
-    "typescript": "^4.4.2",
+    "typescript": "^5.1.6",
     "url": "^0.11.0",
     "webpack": "^5.81.0",
     "webpack-bundle-analyzer": "^4.1.0",

diff --git a/packages/ripple-address-codec/src/index.ts b/packages/ripple-address-codec/src/index.ts
@@ -40,7 +40,7 @@ function encodeXAddress(
     // RIPEMD160 is 160 bits = 20 bytes
     throw new Error('Account ID must be 20 bytes')
   }
-  if (tag > MAX_32_BIT_UNSIGNED_INT) {
+  if (tag !== false && tag > MAX_32_BIT_UNSIGNED_INT) {
     throw new Error('Invalid tag')
   }
   const theTag = tag || 0

diff --git a/packages/ripple-address-codec/tsconfig.json b/packages/ripple-address-codec/tsconfig.json
@@ -11,7 +11,6 @@
     "noUnusedParameters": true,
     "removeComments": false,
     "preserveConstEnums": false,
-    "suppressImplicitAnyIndexErrors": false,
     "skipLibCheck": true,
     "declaration": true,
     "strictNullChecks": true

diff --git a/packages/ripple-binary-codec/tsconfig.json b/packages/ripple-binary-codec/tsconfig.json
@@ -14,7 +14,6 @@
     "noImplicitAny": false,
     "removeComments": false,
     "preserveConstEnums": false,
-    "suppressImplicitAnyIndexErrors": true,
     "skipLibCheck": true,
     "declaration": true
   },

diff --git a/packages/xrpl/package.json b/packages/xrpl/package.json
@@ -44,7 +44,7 @@
     "karma-webpack": "^5.0.0",
     "node-polyfill-webpack-plugin": "^2.0.1",
     "react": "^18.2.0",
-    "typedoc": "^0.24.6"
+    "typedoc": "^0.24.8"
   },
   "resolutions": {
     "elliptic": "^6.5.4"

diff --git a/packages/xrpl/test/createMockRippled.ts b/packages/xrpl/test/createMockRippled.ts
@@ -55,7 +55,7 @@ export type MockedWebSocketServer = WebSocketServer &
     addResponse: (
       command: string,
       response:
-        | Response
+        | BaseResponse
         | ErrorResponse
         | ((r: Request) => Response | ErrorResponse | Record<string, unknown>)
         | Record<string, unknown>,

diff --git a/packages/xrpl/tsconfig.json b/packages/xrpl/tsconfig.json
@@ -12,7 +12,6 @@
     "removeComments": true,
     "preserveConstEnums": false,
     "esModuleInterop": true,
-    "suppressImplicitAnyIndexErrors": false,
     "resolveJsonModule": true,
     "preserveSymlinks": true
   },