Skip to content

Commit

Permalink
feat: remove node 14 support (#2386)
Browse files Browse the repository at this point in the history
  • Loading branch information
ckniffen committed Oct 18, 2023
1 parent 45bc64b commit 2bf14e5
Show file tree
Hide file tree
Showing 8 changed files with 30 additions and 93 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 20.x]
node-version: [16.x, 18.x, 20.x]

steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 20.x]
node-version: [16.x, 18.x, 20.x]

steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -202,7 +202,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 20.x]
node-version: [16.x, 18.x, 20.x]

steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ See the full reference documentation for all classes, methods, and utilities.
4. Subscribing to changes in the ledger ([Ex. ledger, transactions, & more...](https://xrpl.org/subscribe.html))
5. Parsing ledger data into more convenient formats ([`xrpToDrops`](https://js.xrpl.org/functions/xrpToDrops.html) and [`rippleTimeToISOTime`](https://js.xrpl.org/functions/rippleTimeToISOTime.html))

All of which works in Node.js (tested for v14+) & web browsers (tested for Chrome).
All of which works in Node.js (tested for v16+) & web browsers (tested for Chrome).

# Quickstart

### Requirements

+ **[Node.js v16](https://nodejs.org/)** is recommended. We also support v14, v18 and v20. Other versions may work but are not frequently tested.
+ **[Node.js v16](https://nodejs.org/)** is recommended. We also support v18 and v20. Other versions may work but are not frequently tested.

### Installing xrpl.js

Expand Down
99 changes: 18 additions & 81 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"./packages/*"
],
"engines": {
"node": ">=12.0.0",
"npm": ">=7.0.0 < 10.0.0"
"node": ">=16.0.0",
"npm": ">=7.10.0 < 10.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/ripple-address-codec/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
},
"prettier": "@xrplf/prettier-config",
"engines": {
"node": ">= 10"
"node": ">= 16"
}
}
2 changes: 1 addition & 1 deletion packages/ripple-binary-codec/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@
"readmeFilename": "README.md",
"prettier": "@xrplf/prettier-config",
"engines": {
"node": ">= 10"
"node": ">= 16"
}
}
2 changes: 1 addition & 1 deletion packages/ripple-keypairs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@
"license": "ISC",
"prettier": "@xrplf/prettier-config",
"engines": {
"node": ">= 10"
"node": ">= 16"
}
}
4 changes: 2 additions & 2 deletions packages/xrpl/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
},
"devDependencies": {
"@geut/browser-node-core": "^2.0.13",
"@types/node": "^14.18.36",
"@types/node": "^16.18.38",
"assert-browserify": "^2.0.0",
"browserify-fs": "^1.0.0",
"constants-browserify": "^1.0.0",
Expand Down Expand Up @@ -89,6 +89,6 @@
"xrpl"
],
"engines": {
"node": ">=10.13.0"
"node": ">=16.0.0"
}
}

0 comments on commit 2bf14e5

Please sign in to comment.