Skip to content

Commit

Permalink
lint for deprecation
Browse files Browse the repository at this point in the history
  • Loading branch information
achowdhry-ripple committed Nov 13, 2024
1 parent 1a2d37f commit 4b872ab
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/xrpl/src/models/utils/flags.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,10 @@ export function setTransactionFlagsToNumber(tx: Transaction): void {
'This function is deprecated. Use convertTxFlagsToNumber() instead and use the returned value to modify the tx.Flags from the caller.',
)

// eslint-disable-next-line no-param-reassign -- intended param reassign in setter
tx.Flags = convertTxFlagsToNumber(tx)
if (tx.Flags) {
// eslint-disable-next-line no-param-reassign -- intended param reassign in setter
tx.Flags = convertTxFlagsToNumber(tx)
}
}

/**
Expand Down
1 change: 1 addition & 0 deletions packages/xrpl/test/models/utils.test.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable import/no-deprecated -- using deprecated setTransactionFlagsToNumbers to ensure no breaking changes */
/* eslint-disable no-bitwise -- flags require bitwise operations */
import { assert } from 'chai'

Expand Down

0 comments on commit 4b872ab

Please sign in to comment.