Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use isomorphic-ws to clean up bundlers #2410

Closed
wants to merge 1 commit into from

Conversation

ckniffen
Copy link
Collaborator

High Level Overview of Change

This removes the need to specify a mapping in bundler configs for ws. Only downside is that it is 47bytes gzipped larger but with how much less config is needed I think is worth it.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

This removes the need to specify a mapping in bundler configs for `ws`.
Only downside is that it is 47bytes gzipped larger but with how much
less config is needed I think is worth it.
@ckniffen ckniffen added the 3.0 label Jul 26, 2023
@ckniffen ckniffen marked this pull request as draft July 26, 2023 21:04
@ckniffen
Copy link
Collaborator Author

Turns out there is a heavy reliance on the event emitter version of the websocket wrapper. This will require quite the rewrite and will be deprioritized.

@ckniffen ckniffen closed this Jul 26, 2023
@ckniffen ckniffen deleted the feature/use-isomorphic-ws branch July 26, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant