-
Notifications
You must be signed in to change notification settings - Fork 49
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Add XLS-47d Price Oracle objects & transactions * Add unit tests * Cleanup ITs to operate on all rippled & clio nodes and networks. * Update and cleanup Checkstyle --------- Co-authored-by: David Fuelling <[email protected]>
- Loading branch information
Showing
67 changed files
with
3,908 additions
and
468 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
164 changes: 164 additions & 0 deletions
164
xrpl4j-client/src/test/java/org/xrpl/xrpl4j/client/JsonRpcClientTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,164 @@ | ||
| package org.xrpl.xrpl4j.client; | ||
|
|
||
| import static org.assertj.core.api.AssertionsForClassTypes.assertThat; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| import com.fasterxml.jackson.databind.JsonNode; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.Mock; | ||
| import org.mockito.MockitoAnnotations; | ||
|
|
||
| /** | ||
| * Unit test for {@link JsonRpcClient}. | ||
| */ | ||
| class JsonRpcClientTest { | ||
|
|
||
| private JsonRpcClient jsonRpcClient; | ||
|
|
||
| @Mock | ||
| JsonNode jsonResponseNodeMock; // <-- The main response | ||
|
|
||
| @Mock | ||
| JsonNode jsonResultNodeMock; // <-- resp.result | ||
|
|
||
| @Mock | ||
| JsonNode jsonStatusNodeMock; // <-- result.status | ||
|
|
||
| @Mock | ||
| JsonNode jsonErrorNodeMock; // <-- result.error | ||
|
|
||
| @Mock | ||
| JsonNode jsonErrorMessageNodeMock; // <-- result.error_message | ||
|
|
||
| @Mock | ||
| JsonNode jsonErrorExceptionNodeMock; // <-- result.error_exception | ||
|
|
||
| @BeforeEach | ||
| void setUp() { | ||
| MockitoAnnotations.openMocks(this); | ||
| jsonRpcClient = rpcRequest -> jsonResponseNodeMock; | ||
|
|
||
| // See https://xrpl.org/docs/references/http-websocket-apis/api-conventions/error-formatting/#json-rpc-format | ||
| when(jsonStatusNodeMock.asText()).thenReturn(JsonRpcClient.ERROR); | ||
|
|
||
| when(jsonErrorNodeMock.asText()).thenReturn("error_foo"); | ||
| when(jsonErrorMessageNodeMock.asText()).thenReturn("error_message_foo"); | ||
| when(jsonErrorExceptionNodeMock.asText()).thenReturn("error_exception_foo"); | ||
|
|
||
| // By default, there's a result. | ||
| when(jsonResponseNodeMock.has("result")).thenReturn(true); | ||
| when(jsonResponseNodeMock.get("result")).thenReturn(jsonResultNodeMock); | ||
|
|
||
| // By default, there's an error. | ||
| when(jsonResultNodeMock.has("status")).thenReturn(true); | ||
| when(jsonResultNodeMock.get("status")).thenReturn(jsonStatusNodeMock); | ||
|
|
||
| hasError(true); // <-- By default, there's a `result.error` | ||
| hasErrorMessage(false); // <-- By default, there's no `result.error_message` | ||
| hasErrorException(false); // <-- By default, there's no `result.error_exception` | ||
| } | ||
|
|
||
| ////////////////// | ||
| // checkForError() | ||
| ////////////////// | ||
|
|
||
| @Test | ||
| void testCheckForErrorWhenResponseHasNoResultField() throws JsonRpcClientErrorException { | ||
| // Do nothing if no "result" field | ||
| when(jsonResponseNodeMock.has("result")).thenReturn(false); | ||
| jsonRpcClient.checkForError(jsonResponseNodeMock); // <-- No error should be thrown. | ||
| } | ||
|
|
||
| @Test | ||
| void testCheckForErrorWhenResponseHasNoStatusFields() throws JsonRpcClientErrorException { | ||
| when(jsonResultNodeMock.has("status")).thenReturn(false); | ||
| jsonRpcClient.checkForError(jsonResponseNodeMock); | ||
| } | ||
|
|
||
| @Test | ||
| void testCheckForErrorWhenResponseHasNoErrorFields() throws JsonRpcClientErrorException { | ||
| hasError(false); | ||
| jsonRpcClient.checkForError(jsonResponseNodeMock); | ||
| } | ||
|
|
||
| @Test | ||
| void testCheckForErrorWhenResponseHasResultErrorException() { | ||
| hasErrorException(true); | ||
|
|
||
| JsonRpcClientErrorException error = assertThrows( | ||
| JsonRpcClientErrorException.class, | ||
| () -> jsonRpcClient.checkForError(jsonResponseNodeMock) | ||
| ); | ||
| assertThat(error.getMessage()).isEqualTo("error_foo (error_exception_foo)"); | ||
| } | ||
|
|
||
| @Test | ||
| void testCheckForErrorWhenResponseHasResultErrorMessage() { | ||
| hasErrorMessage(true); | ||
|
|
||
| JsonRpcClientErrorException error = assertThrows( | ||
| JsonRpcClientErrorException.class, | ||
| () -> jsonRpcClient.checkForError(jsonResponseNodeMock) | ||
| ); | ||
| assertThat(error.getMessage()).isEqualTo("error_foo (error_message_foo)"); | ||
| } | ||
|
|
||
| @Test | ||
| void testCheckForErrorWhenResponseHasResultError() { | ||
| hasError(true); | ||
|
|
||
| JsonRpcClientErrorException error = assertThrows(JsonRpcClientErrorException.class, | ||
| () -> jsonRpcClient.checkForError(jsonResponseNodeMock)); | ||
| assertThat(error.getMessage()).isEqualTo("error_foo (n/a)"); | ||
| } | ||
|
|
||
| @Test | ||
| void testCheckForErrorWhenResponseHasAll() { | ||
| hasError(true); | ||
| hasErrorMessage(true); | ||
| hasErrorMessage(true); | ||
|
|
||
| JsonRpcClientErrorException error = assertThrows( | ||
| JsonRpcClientErrorException.class, | ||
| () -> jsonRpcClient.checkForError(jsonResponseNodeMock) | ||
| ); | ||
| assertThat(error.getMessage()).isEqualTo("error_foo (error_message_foo)"); | ||
| } | ||
|
|
||
| ////////////////// | ||
| // Private Helpers | ||
| ////////////////// | ||
|
|
||
| private void hasError(boolean hasError) { | ||
| when(jsonResultNodeMock.has(JsonRpcClient.ERROR)).thenReturn(hasError); | ||
| if (hasError) { | ||
| when(jsonResultNodeMock.get(JsonRpcClient.ERROR)).thenReturn(jsonErrorNodeMock); | ||
| when(jsonResultNodeMock.hasNonNull(JsonRpcClient.ERROR)).thenReturn(true); | ||
| } else { | ||
| when(jsonResultNodeMock.get(JsonRpcClient.ERROR)).thenReturn(null); | ||
| } | ||
| } | ||
|
|
||
| private void hasErrorMessage(boolean hasErrorMessage) { | ||
| when(jsonResultNodeMock.has(JsonRpcClient.ERROR_MESSAGE)).thenReturn(hasErrorMessage); | ||
| if (hasErrorMessage) { | ||
| when(jsonResultNodeMock.get(JsonRpcClient.ERROR_MESSAGE)).thenReturn(jsonErrorMessageNodeMock); | ||
| when(jsonResultNodeMock.hasNonNull(JsonRpcClient.ERROR_MESSAGE)).thenReturn(true); | ||
| } else { | ||
| when(jsonResultNodeMock.get(JsonRpcClient.ERROR_MESSAGE)).thenReturn(null); | ||
| } | ||
| } | ||
|
|
||
| private void hasErrorException(boolean hasErrorException) { | ||
| when(jsonResultNodeMock.has(JsonRpcClient.ERROR_EXCEPTION)).thenReturn(hasErrorException); | ||
| if (hasErrorException) { | ||
| when(jsonResultNodeMock.get(JsonRpcClient.ERROR_EXCEPTION)).thenReturn(jsonErrorExceptionNodeMock); | ||
| when(jsonResultNodeMock.hasNonNull(JsonRpcClient.ERROR_EXCEPTION)).thenReturn(true); | ||
| } else { | ||
| when(jsonResultNodeMock.get(JsonRpcClient.ERROR_EXCEPTION)).thenReturn(null); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.