Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): replace lzma with xz when using nix #743

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

tdeebswihart
Copy link
Contributor

I encountered the following problem today when omni attempted to install python in the background:

[1/5] - python (3): deps: evaluating file '/nix/store/93haqkb7bl8l90vpfqgkygrd5l13gafm-source/pkgs/by-name/gd/gdbm/package.nix'
[1/5] - python (3): deps: error:
[1/5] - python (3): deps:        … while calling the 'derivationStrict' builtin
[1/5] - python (3): deps:          at <nix/derivation-internal.nix>:34:12:
[1/5] - python (3): deps:            33|
[1/5] - python (3): deps:            34|   strict = derivationStrict drvAttrs;
[1/5] - python (3): deps:              |            ^
[1/5] - python (3): deps:            35|
[1/5] - python (3): deps:        … while evaluating derivation 'nix-shell'
[1/5] - python (3): deps:          whose name attribute is located at /nix/store/93haqkb7bl8l90vpfqgkygrd5l13gafm-source/pkgs/stdenv/generic/make-derivation.nix:336:7
[1/5] - python (3): deps:        … while evaluating attribute '__impureHostDeps' of derivation 'nix-shell'
[1/5] - python (3): deps:          at /nix/store/93haqkb7bl8l90vpfqgkygrd5l13gafm-source/pkgs/stdenv/generic/make-derivation.nix:451:7:
[1/5] - python (3): deps:           450|       __propagatedSandboxProfile = unique (computedPropagatedSandboxProfile ++ [ propagatedSandboxProfile ]);
[1/5] - python (3): deps:           451|       __impureHostDeps = computedImpureHostDeps ++ computedPropagatedImpureHostDeps ++ __propagatedImpureHostDeps ++ __impureHostDeps ++ stdenv.__extraImpureHostDeps ++ [
[1/5] - python (3): deps:              |       ^
[1/5] - python (3): deps:           452|         "/dev/zero"
[1/5] - python (3): deps:        (stack trace truncated; use '--show-t
[1/5] - python (3): deps: race' to show the full, detailed trace)
[1/5] - python (3): deps:        error: 'lzma' has been renamed to/replaced by 'xz'
[1/5] - python (3): deps: failed to install nix packages: execution error: process exited with status 1; log is available at /var/folders/f0/_2j81h0s4_zf6kjr5qkczmbr0000gn/T/omni-exec.20241031T182130Z.h5Gqe4

It looks like lzma is simply an alias for xz, and that the alias has been removed. I run against nightly nix (at whatever my flake is at now), so I may be ahead of your normal testing.

Since lzma is an alias this should work on both nightly and stable nix

@github-actions github-actions bot added the rust Pull requests that update Rust code label Oct 31, 2024
@XaF XaF enabled auto-merge (squash) October 31, 2024 18:40
auto-merge was automatically disabled October 31, 2024 19:38

Head branch was pushed to by a user without write access

@XaF XaF merged commit 7b8d702 into XaF:main Oct 31, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants