Moving PS Kernel's pscontext to public XRT include area and under XRT namespace #7629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 14, 2023 10:03
…tory Signed-off-by: Jeff Lin <[email protected]>
Signed-off-by: Jeff Lin <[email protected]>
jeffli-xilinx
requested review from
sonals,
stsoe,
rozumx,
chvamshi-xilinx,
uday610 and
vboggara-xilinx
as code owners
jeffli-xilinx
requested review from
nishraptor
and removed request for
vboggara-xilinx
stsoe
requested changes
Jul 16, 2023
|
|
||
| #include "xrt/detail/config.h" | ||
| #include "xrt/detail/pimpl.h" | ||
| #include "xclhal2.h" |
There was a problem hiding this comment.
Suggested change
| #include "xclhal2.h" |
| class pscontext_impl; | ||
| class pscontext : public detail::pimpl<pscontext_impl> { | ||
| public: | ||
| pscontext() = default; |
There was a problem hiding this comment.
This does not look right. Where is the pscontext_impl constructed?
| #include <memory> | ||
|
|
||
| /* | ||
| * PS Context Data Structure to be derived from for user's xrtHandle class |
There was a problem hiding this comment.
This comment doesn't reflect usage. The comment is for xrt::pscontext presumably, but that class is not derived from user's xrt_handle class. Next line of comment is correct though.
Also can we use xrt_handle rather than camelCase. There is no camelCase in xrt exposed APIs.
| * public: | ||
| * xrt::device dhdl; | ||
| * xrt::kernel kernel; | ||
| * xrtHandles(xclDeviceHandle dhdl_in, const xuid_t xclbin_uuid) |
There was a problem hiding this comment.
Do not use xclDeviceHandle use xrt::device.
And use xrt::uuid instead of plain uuid_t (aka xuid_t).
| * xrt::kernel kernel; | ||
| * xrtHandles(xclDeviceHandle dhdl_in, const xuid_t xclbin_uuid) | ||
| * : dhdl(dhdl_in) | ||
| * , kernel(dhdl,xclbin_uuid,"kernel name") |
There was a problem hiding this comment.
Suggested change
| * , kernel(dhdl,xclbin_uuid,"kernel name") | |
| * , kernel(dhdl, xclbin_uuid, "kernel name") |
|
Build Passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Moved pscontext class used in PS kernels to XRT's public include areas and under XRT namespace.
Header is now called xrt_pscontext.h, and sk_types.h should no longer be used.
Also updated all the current PS kernels under XRT repo to use this new header file.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
All the existing PS kernel need to be updated to use the new pscontext class under XRT namespace
What has been tested and how, request additional testing if necessary
Tested on v70
Documentation impact (if any)