Deprecate sk_types.h and move pscontext class to a separate file pscontext.h #7632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntext.h Signed-off-by: Jeff Lin <[email protected]>
jeffli-xilinx
requested review from
sonals,
stsoe and
chvamshi-xilinx
as code owners
|
Build Passed! |
stsoe
approved these changes
Jul 21, 2023
sonals
reviewed
Jul 24, 2023
sonals
reviewed
Jul 24, 2023
Signed-off-by: Jeff Lin <[email protected]>
sonals
approved these changes
Jul 24, 2023
|
Build Passed! |
chvamshi-xilinx
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Move pscontext class out of sk_types.h and make sk_types.h to be deprecated
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)