CR-1159280: Fixing profiling table to correctly associate argument with connection #7640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Profiling tables that report data movement between kernels and memory report the original kernel arguments associated with the connection. With connections to host memory via host bridge, this association was not correctly made and the tables had empty entries. Additionally, if multiple kernels were present in a design and had arguments with the same name, they were incorrectly being reported as attached to the wrong memory component.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
The issue was discovered through comprehensive regression testing.
How problem was solved, alternative solutions (if any) and why they were rejected
This change explicitly adds a check for host bridge connections. Additionally, it changes the argument to memory mapping data structure to make the connection on a compute unit basis rather than a kernel basis, so multiple kernels with identical named arguments don't overwrite each other.
Risks (if any) associated the changes in the commit
Low risk as this should only affect information reported in a single table.
What has been tested and how, request additional testing if necessary
Tested on original failing test case.
Documentation impact (if any)
No documentation impact