Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR-1173328 xbmgmt configure does not detect bad arguments #7686

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

dbenusov
Copy link
Contributor

Problem solved by the commit

https://jira.xilinx.com/browse/CR-1173328
xbmgmt configure does not report incorrect options.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

Introduced in #7571

How problem was solved, alternative solutions (if any) and why they were rejected

Added an additional argument check that validates the arguments after validating no suboptions have been invoked. Since SubCmdConfigure is somewhat of a special case, this is the simplest solution!

Risks (if any) associated the changes in the commit

None. This is a bug fix.

What has been tested and how, request additional testing if necessary

Ubuntu 22.04 VCK5000

root@xsjdbenusov50:/proj/rdi/staff/dbenusov# xbmgmt configure --output
WARNING: Unexpected xclmgmt version (2.14.0) was found. Expected 2.16.0, to match XRT tools.
ERROR: Unrecognized arguments:
  --output


COMMAND: configure

DESCRIPTION: Advanced options for configuring a device

USAGE: xbmgmt configure [ --input arg | [--retention arg] ] [--help] [-d arg]

OPTIONS:
  -d, --device       - The Bus:Device.Function (e.g., 0000:d8:00.0) device of interest
  --help             - Help to use this sub-command
  --input            - Takes an INI file with configuration details (e.g. memory, clock throttling)
                       and loads them onto the device
  --retention        - Enables / Disables memory retention. Valid values are: [ENABLE | DISABLE]


GLOBAL OPTIONS:
  --verbose          - Turn on verbosity
  --batch            - Enable batch mode (disables escape characters)
  --force            - When possible, force an operation

Documentation impact (if any)

None

@dbenusov dbenusov marked this pull request as ready for review August 31, 2023 18:56
@gbuildx
Copy link
Collaborator

gbuildx commented Aug 31, 2023

Build Passed!

@chvamshi-xilinx chvamshi-xilinx merged commit 71a763f into Xilinx:master Sep 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants