[CR-1161728]: emconfig.json path issue if host code is in python. #7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgundime-xilinx
requested review from
chvamshi-xilinx and
venkatp-xilinx
as code owners
|
Build failed :( |
sgundime-xilinx
changed the title
chvamshi-xilinx
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Hi @sgundime-xilinx ,
It is better to check the emconfig.json file in the executable path first. If we dont find it there, check in current working directory. We shouldn't be adding special checks for python etc.
|
retest this please. |
|
Build failed :( |
chvamshi-xilinx
approved these changes
Sep 6, 2023
venkatp-xilinx
approved these changes
Sep 6, 2023
|
Build Passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: emconfig.json file path is wrongly deduced with getSelfPath API especially if host code is python script. The current fix ensures the proper current path is chosen if the exe name contains /usr/*/python in it.
Risk: very low
Tests: Canary Run. Results are Clean.
Reviewer: venkatp