CR-1174424: empty graph based interface tile trace #7693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Schumacher <[email protected]>
|
Build Passed! |
jvillarre
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
interface tile trace was not requesting or configuring stream switch monitor ports correctly
How problem was solved, alternative solutions (if any) and why they were rejected
correct how monitor ports are requested using the minimum
Risks (if any) associated the changes in the commit
only affects specific metric sets in trace (e.g., interface tiles)
What has been tested and how, request additional testing if necessary
tested CR design on vck190; also testing on vek280
Documentation impact (if any)
none