Return ENODATA Error code if bitstream is not present #7694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manoj Takasi <[email protected]>
chvamshi-xilinx
approved these changes
Sep 6, 2023
ManojTakasi
changed the title
|
Build Passed! |
chvamshi-xilinx
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
CR-1128292 If bitstream is not present in the xclbin. We need to give different error code instead of EINVAL.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
NA
How problem was solved, alternative solutions (if any) and why they were rejected
Added check in the icap_download_hw() function. If the bitstream is not present we are returning the ENODATA code and printing it is dmesg log.
Risks (if any) associated the changes in the commit
No
What has been tested and how, request additional testing if necessary
Teseted on U250.
Documentation impact (if any)
No