Added AIE Profiling on additional Windows Devices #7714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
…t_int.h in order to create the hw context from the raw hw_context_impl pointer Signed-off-by: Nishant Mysore <[email protected]>
…ie profiling plugin Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
nishraptor
requested review from
jvillarre,
stsoe,
vboggara-xilinx,
rozumx and
uday610
as code owners
Signed-off-by: Nishant Mysore <[email protected]>
stsoe
requested changes
Sep 20, 2023
Signed-off-by: Nishant Mysore <[email protected]>
Signed-off-by: Nishant Mysore <[email protected]>
|
Build failed :( |
…NIMAL_BUILD Signed-off-by: Nishant Mysore <[email protected]>
|
Build failed :( |
Signed-off-by: Nishant Mysore <[email protected]>
|
Build Passed! |
stsoe
approved these changes
Sep 21, 2023
Removed empty line Co-authored-by: Soren Soe <[email protected]>
|
Build Passed! |
jvillarre
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Added AIE Profiling support on IPU devices.
How problem was solved, alternative solutions (if any) and why they were rejected
A new AIE Profile plugin is compiled only on windows devices. The plugin configure/poll calls are now within the xrt hardware context creation/destruction in order to ensure that the XRT kernels are valid and that the AIE is in a valid state for reading counters after the application has completed. AIE configuration occurs when the hardware context is created, and the counters are profiled once when the hardware context is being destroyed. The raw hw_context_impl void* is passed to the aie_profile callback, which then uses the new method defined in hw_context_int in order to construct a xrt::hw_context from the implementation shared pointer.
Risks (if any) associated the changes in the commit
Could have effects on V70/VCK5000 or VCK190 AIE profiling.
What has been tested and how, request additional testing if necessary
Built and verified on windows machines
Documentation impact (if any)