Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR-1214433, CR-1214577 and CR-1215195 #8507

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Conversation

AShivangi
Copy link
Collaborator

Problem solved by the commit

  • CR-1214433 Error message when gemm test fails appears to be confusing
  • CR-1214577 xrt-smi validate does not printing power mode properly or help message is not clear
  • CR-1215195 validate with "--run=" doesn't print the help
  • add returns to mark the tests failed correctly

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

DSV testing

How problem was solved, alternative solutions (if any) and why they were rejected

  • Check the context creation failed error ID coming from the driver and wrap it in the userspace
  • Add some messages in verbose mode and improve help verbiage. After some internal discussion, we have decided to make this a hidden option as this was requested internally
  • add try/catch

Risks (if any) associated the changes in the commit

Low

What has been tested and how, request additional testing if necessary

Tested on Strix
CR 1:

> xrt-smi validate -r latency --pmode default --verbose
Verbose: Enabling Verbosity
Verbose: Sub command: --pmode
Verbose: Setting power mode to `default`

Validate Device           : [00c5:00:01.1]
    Platform              : NPU
    Power Mode            : Default
-------------------------------------------------------------------------------
Test 1 [00c5:00:01.1]     : latency
    Description           : Run end-to-end latency test
    Benchmarks            : <>
    Details               : Threshold is <> us
    Xclbin                : <>
    Details               : Kernel name is 'DPU_PDI_0'
                            Instruction size: 20 bytes
                            No. of iterations: 10000
                            Average latency: <> us
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Validation completed


>xrt-smi validate -r latency --verbose
Verbose: Enabling Verbosity
Verbose: Setting power mode to `performance`

Validate Device           : [00c5:00:01.1]
    Platform              : NPU
    Power Mode            : Performance
-------------------------------------------------------------------------------
Test 1 [00c5:00:01.1]     : latency
    Description           : Run end-to-end latency test
    Benchmarks            : <>
    Details               : Threshold is <> us
    Xclbin                : <>
    Details               : Kernel name is 'DPU_PDI_0'
                            Instruction size: 20 bytes
                            No. of iterations: 10000
                            Average latency: <> us
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Validation completed

CR 2:

>xrt-smi validate -r gemm
Validate Device           : [00c5:00:01.1]
    Platform              : NPU
    Power Mode            : Performance
-------------------------------------------------------------------------------
Verbose: Enabling Verbosity
Test 1 [00c5:00:01.1]     : gemm
    Description           : Measure the TOPS value of GEMM operations
    Benchmarks            : <>
    Details               : Threshold is <> TOPS
    Xclbin                : <>
    Details               : Kernel name is 'DPU_1x4'
    Error(s)              : Not enough columns available. Please make sure not other
                            workload is running on the device.
    Test Status           : [FAILED]
-------------------------------------------------------------------------------
Validation failed

CR 3:

$ xrt-smi validate --run=
the argument for option '--run' should follow immediately after the equal sign

DESCRIPTION: The Xilinx (R) Run Time - System Management Interface (xrt-smi) is a standalone
             command line utility that is included with the Xilinx Run Time (XRT) installation
             package. It includes multiple commands to identify and validate the installed card(s).
             
             This information can be used for both card administration and application debugging.

USAGE: xrt-smi[--help] [--version] [--verbose] [--batch] [--force] [command [commandArgs]]

AVAILABLE COMMANDS:
  configure  - Device and host configuration
  examine    - Status of the system and device
  program    - Download the acceleration program to a given device
  reset      - Resets the given device
  validate   - Validates the basic shell acceleration functionality

OPTIONS:
  --help             - Help to use this application
  --version          - Report the version of XRT and its drivers
  --verbose          - Turn on verbosity
  --batch            - Enable batch mode (disables escape characters)
  --force            - When possible, force an operation

Documentation impact (if any)

N/A

Signed-off-by: AShivangi <[email protected]>
Signed-off-by: AShivangi <[email protected]>
Signed-off-by: AShivangi <[email protected]>
Signed-off-by: AShivangi <[email protected]>
@AShivangi AShivangi requested a review from rchane October 8, 2024 20:56
Copy link
Collaborator

@rchane rchane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Signed-off-by: AShivangi <[email protected]>
Copy link
Collaborator

@aktondak aktondak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@stsoe stsoe merged commit c2b7bbb into Xilinx:master Oct 14, 2024
18 checks passed
@AShivangi AShivangi deleted the handle-fail branch October 14, 2024 17:03
chvamshi-xilinx added a commit that referenced this pull request Oct 23, 2024
* Spatial Sharing test update for low variance (#8506)

* Spatial Sharing test update for low variance

Signed-off-by: Akshay Tondak <[email protected]>

* Header correction

Signed-off-by: Akshay Tondak <[email protected]>

* Update TestValidateUtilities.h

* Fix for XRT build fail

Signed-off-by: Akshay Tondak <[email protected]>

* Review comment changes

Signed-off-by: Akshay Tondak <[email protected]>

---------

Signed-off-by: Akshay Tondak <[email protected]>
Co-authored-by: Akshay Tondak <[email protected]>
(cherry picked from commit 40ed432)

* CR-1214433, CR-1214577 and CR-1215195 (#8507)

* CRs

Signed-off-by: AShivangi <[email protected]>

* CR-1215195

Signed-off-by: AShivangi <[email protected]>

* remove --pmode msging

Signed-off-by: AShivangi <[email protected]>

* change messaging for all tests

Signed-off-by: AShivangi <[email protected]>

* fix typo

Signed-off-by: AShivangi <[email protected]>

* fix error handling

Signed-off-by: AShivangi <[email protected]>

* fix build

---------

Signed-off-by: AShivangi <[email protected]>
(cherry picked from commit c2b7bbb)

* VITIS-13557 Display clocks on-demand (#8520)

* move clock reporting to advanced

Signed-off-by: AShivangi <[email protected]>

* rename some files

Signed-off-by: AShivangi <[email protected]>

---------

Signed-off-by: AShivangi <[email protected]>
(cherry picked from commit 344019f)

* Vitis 12999 : Temporal Sharing overhead benchmark test (#8516)

* Spatial Sharing test update for low variance

Signed-off-by: Akshay Tondak <[email protected]>

* Adding missing file

Signed-off-by: Akshay Tondak <[email protected]>

* Temporal sharing v1

Signed-off-by: Akshay Tondak <[email protected]>

* Temporal Sharing Overhead test final for PR

Signed-off-by: Akshay Tondak <[email protected]>

* Update TestTemporalSharingOvd.h

* Threshold Logic Addition

Signed-off-by: Akshay Tondak <[email protected]>

* Threshold changes update

Signed-off-by: Akshay Tondak <[email protected]>

* Update TestTemporalSharingOvd.cpp

* Update to temporal sharing test after XrtSmiUtilities changes

Signed-off-by: Akshay Tondak <[email protected]>

* Merge conflic fixes

Signed-off-by: Akshay Tondak <[email protected]>

* Removing extra header inclusions

Signed-off-by: Akshay Tondak <[email protected]>

* DCO Remediation Commit for Akshay Tondak <[email protected]>

I, Akshay Tondak <[email protected]>, hereby add my Signed-off-by to this commit: 18c6592
I, Akshay Tondak <[email protected]>, hereby add my Signed-off-by to this commit: eebad9c

Signed-off-by: Akshay Tondak <[email protected]>

* Fix for build fail

Signed-off-by: Akshay Tondak <[email protected]>

* DCO Remediation Commit for Akshay Tondak <[email protected]>

I, Akshay Tondak <[email protected]>, hereby add my Signed-off-by to this commit: 18c6592
I, Akshay Tondak <[email protected]>, hereby add my Signed-off-by to this commit: eebad9c

Signed-off-by: Akshay Tondak <[email protected]>

Signed-off-by: Akshay Tondak <[email protected]>

---------

Signed-off-by: Akshay Tondak <[email protected]>
Co-authored-by: Akshay Tondak <[email protected]>

* CR-1216849, CR-1217061 FIX : xrt-smi configure --pmode default --help` does not print global options (#8532)

* CR-1216849 fix

Signed-off-by: Akshay Tondak <[email protected]>

* CR-1217061 fix

Signed-off-by: Akshay Tondak <[email protected]>

---------

Signed-off-by: Akshay Tondak <[email protected]>
Co-authored-by: Akshay Tondak <[email protected]>
(cherry picked from commit 422826c)

* Fixes for upcoming release (#8537)

* fixes

Signed-off-by: AShivangi <[email protected]>

* add a missing pass token

Signed-off-by: AShivangi <[email protected]>

---------

Signed-off-by: AShivangi <[email protected]>
(cherry picked from commit 78681ef)

* Remove max tops (#8543)

* remove max tops and preemption msg handling

Signed-off-by: AShivangi <[email protected]>

* remove tops only

Signed-off-by: AShivangi <[email protected]>

---------

Signed-off-by: AShivangi <[email protected]>
(cherry picked from commit f603d05)

* CR-1217061 revert (#8540)

Signed-off-by: Akshay Tondak <[email protected]>
Co-authored-by: Akshay Tondak <[email protected]>
(cherry picked from commit 56d452c)

* CR-1206954 fix : Change the text displayed by xrt-smi help (#8554)

* CR-1206954 fix

Signed-off-by: Akshay Tondak <[email protected]>

* updating wording

Signed-off-by: Akshay Tondak <[email protected]>

* Updated wording

Signed-off-by: Akshay Tondak <[email protected]>

* Updated description after reviews

Signed-off-by: Akshay Tondak <[email protected]>

* Updating message after reviews

Signed-off-by: Akshay Tondak <[email protected]>

---------

Signed-off-by: Akshay Tondak <[email protected]>
Co-authored-by: Akshay Tondak <[email protected]>
(cherry picked from commit b97f868)

* enabling external buffer logic as latest petalinux has ssw change (#8517)

Signed-off-by: ch vamshi krishna <[email protected]>
Co-authored-by: ch vamshi krishna <[email protected]>
(cherry picked from commit ad4be07)

---------

Signed-off-by: Akshay Tondak <[email protected]>
Co-authored-by: Akshay Tondak <[email protected]>
Co-authored-by: Akshay Tondak <[email protected]>
Co-authored-by: Ch Vamshi Krishna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants