Vitis 12999 : Temporal Sharing overhead benchmark test #8516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
aktondak
requested review from
rozumx,
chvamshi-xilinx and
AShivangi
as code owners
|
Can one of the admins verify this patch? |
aktondak
changed the title
added 3 commits
October 11, 2024 12:02
I, Akshay Tondak <[email protected]>, hereby add my Signed-off-by to this commit: 18c6592 I, Akshay Tondak <[email protected]>, hereby add my Signed-off-by to this commit: eebad9c Signed-off-by: Akshay Tondak <[email protected]>
Signed-off-by: Akshay Tondak <[email protected]>
I, Akshay Tondak <[email protected]>, hereby add my Signed-off-by to this commit: 18c6592 I, Akshay Tondak <[email protected]>, hereby add my Signed-off-by to this commit: eebad9c Signed-off-by: Akshay Tondak <[email protected]> Signed-off-by: Akshay Tondak <[email protected]>
AShivangi
approved these changes
Oct 12, 2024
rchane
approved these changes
Oct 14, 2024
chvamshi-xilinx
added a commit
that referenced
this pull request
Oct 23, 2024
* Spatial Sharing test update for low variance (#8506) * Spatial Sharing test update for low variance Signed-off-by: Akshay Tondak <[email protected]> * Header correction Signed-off-by: Akshay Tondak <[email protected]> * Update TestValidateUtilities.h * Fix for XRT build fail Signed-off-by: Akshay Tondak <[email protected]> * Review comment changes Signed-off-by: Akshay Tondak <[email protected]> --------- Signed-off-by: Akshay Tondak <[email protected]> Co-authored-by: Akshay Tondak <[email protected]> (cherry picked from commit 40ed432) * CR-1214433, CR-1214577 and CR-1215195 (#8507) * CRs Signed-off-by: AShivangi <[email protected]> * CR-1215195 Signed-off-by: AShivangi <[email protected]> * remove --pmode msging Signed-off-by: AShivangi <[email protected]> * change messaging for all tests Signed-off-by: AShivangi <[email protected]> * fix typo Signed-off-by: AShivangi <[email protected]> * fix error handling Signed-off-by: AShivangi <[email protected]> * fix build --------- Signed-off-by: AShivangi <[email protected]> (cherry picked from commit c2b7bbb) * VITIS-13557 Display clocks on-demand (#8520) * move clock reporting to advanced Signed-off-by: AShivangi <[email protected]> * rename some files Signed-off-by: AShivangi <[email protected]> --------- Signed-off-by: AShivangi <[email protected]> (cherry picked from commit 344019f) * Vitis 12999 : Temporal Sharing overhead benchmark test (#8516) * Spatial Sharing test update for low variance Signed-off-by: Akshay Tondak <[email protected]> * Adding missing file Signed-off-by: Akshay Tondak <[email protected]> * Temporal sharing v1 Signed-off-by: Akshay Tondak <[email protected]> * Temporal Sharing Overhead test final for PR Signed-off-by: Akshay Tondak <[email protected]> * Update TestTemporalSharingOvd.h * Threshold Logic Addition Signed-off-by: Akshay Tondak <[email protected]> * Threshold changes update Signed-off-by: Akshay Tondak <[email protected]> * Update TestTemporalSharingOvd.cpp * Update to temporal sharing test after XrtSmiUtilities changes Signed-off-by: Akshay Tondak <[email protected]> * Merge conflic fixes Signed-off-by: Akshay Tondak <[email protected]> * Removing extra header inclusions Signed-off-by: Akshay Tondak <[email protected]> * DCO Remediation Commit for Akshay Tondak <[email protected]> I, Akshay Tondak <[email protected]>, hereby add my Signed-off-by to this commit: 18c6592 I, Akshay Tondak <[email protected]>, hereby add my Signed-off-by to this commit: eebad9c Signed-off-by: Akshay Tondak <[email protected]> * Fix for build fail Signed-off-by: Akshay Tondak <[email protected]> * DCO Remediation Commit for Akshay Tondak <[email protected]> I, Akshay Tondak <[email protected]>, hereby add my Signed-off-by to this commit: 18c6592 I, Akshay Tondak <[email protected]>, hereby add my Signed-off-by to this commit: eebad9c Signed-off-by: Akshay Tondak <[email protected]> Signed-off-by: Akshay Tondak <[email protected]> --------- Signed-off-by: Akshay Tondak <[email protected]> Co-authored-by: Akshay Tondak <[email protected]> * CR-1216849, CR-1217061 FIX : xrt-smi configure --pmode default --help` does not print global options (#8532) * CR-1216849 fix Signed-off-by: Akshay Tondak <[email protected]> * CR-1217061 fix Signed-off-by: Akshay Tondak <[email protected]> --------- Signed-off-by: Akshay Tondak <[email protected]> Co-authored-by: Akshay Tondak <[email protected]> (cherry picked from commit 422826c) * Fixes for upcoming release (#8537) * fixes Signed-off-by: AShivangi <[email protected]> * add a missing pass token Signed-off-by: AShivangi <[email protected]> --------- Signed-off-by: AShivangi <[email protected]> (cherry picked from commit 78681ef) * Remove max tops (#8543) * remove max tops and preemption msg handling Signed-off-by: AShivangi <[email protected]> * remove tops only Signed-off-by: AShivangi <[email protected]> --------- Signed-off-by: AShivangi <[email protected]> (cherry picked from commit f603d05) * CR-1217061 revert (#8540) Signed-off-by: Akshay Tondak <[email protected]> Co-authored-by: Akshay Tondak <[email protected]> (cherry picked from commit 56d452c) * CR-1206954 fix : Change the text displayed by xrt-smi help (#8554) * CR-1206954 fix Signed-off-by: Akshay Tondak <[email protected]> * updating wording Signed-off-by: Akshay Tondak <[email protected]> * Updated wording Signed-off-by: Akshay Tondak <[email protected]> * Updated description after reviews Signed-off-by: Akshay Tondak <[email protected]> * Updating message after reviews Signed-off-by: Akshay Tondak <[email protected]> --------- Signed-off-by: Akshay Tondak <[email protected]> Co-authored-by: Akshay Tondak <[email protected]> (cherry picked from commit b97f868) * enabling external buffer logic as latest petalinux has ssw change (#8517) Signed-off-by: ch vamshi krishna <[email protected]> Co-authored-by: ch vamshi krishna <[email protected]> (cherry picked from commit ad4be07) --------- Signed-off-by: Akshay Tondak <[email protected]> Co-authored-by: Akshay Tondak <[email protected]> Co-authored-by: Akshay Tondak <[email protected]> Co-authored-by: Ch Vamshi Krishna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
https://jira.xilinx.com/browse/VITIS-12999 : Temporal Sharing Overhead Benchmark Test
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
https://jira.xilinx.com/browse/VITIS-12999
How problem was solved, alternative solutions (if any) and why they were rejected
The enhancement was made via a 2-phase test comparison between 2 threaded 2 hardware context run and a 4-threaded temporally shared hardware contexts to calculate time overhead. More details :
https://confluence.amd.com/display/~aktondak/spatial+sharing+overhead+via+xrt-smi+validate
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Needs testing from DSV
Documentation impact (if any)
None