Fix build scripts for MSVC to honor custom ext path #8552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug in build22.bat when `-ext` is specified. Add `-ext` option to build-win22.sh. With Xilinx#8551 the default external dependency location for windows has moved to `c:\Xilinx\XRT\ext.new`. Use the `-ext` option to override the location if desired. Signed-off-by: Soren Soe <[email protected]>
stsoe
force-pushed
the
fix_build_scripts
branch
from
5a4e5f8
to
6faf5dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Fix bug in build22.bat when
-extis specified.Add
-extoption to build-win22.sh.With #8551 the default external dependency location for windows has moved to
c:\Xilinx\XRT\ext.new. Use the-extoption to override the location if desired.