Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VITIS-13786 Update aie partition report to show active and suspended contexts #8583

Merged
merged 3 commits into from
Oct 30, 2024
Merged

VITIS-13786 Update aie partition report to show active and suspended contexts #8583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf6790b
VITIS-13786 Update aie partition report
rchane Oct 29, 2024
db98799
Lowercase status field
rchane Oct 29, 2024
e9a6450
Fix table2d to have single dividers
rchane Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/runtime_src/core/common/query_requests.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1768,6 +1768,7 @@ struct aie_partition_info : request
uint64_t start_col;
uint64_t num_cols;
int pid;
bool is_suspended;
uint64_t instruction_mem;
uint64_t command_submissions;
uint64_t command_completions;
Expand Down
6 changes: 4 additions & 2 deletions src/runtime_src/core/tools/common/Table2D.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ void
Table2D::appendToOutput(std::string& output, const std::string& prefix, const std::string& suffix, const ColumnData& column, const std::string& data) const
{
// Format for table data
boost::format fmt("%s|%s%s%s%s|");
boost::format fmt("%s%s%s%s%s|");
size_t left_blanks = 0;
size_t right_blanks = 0;
getBlankSizes(column, data.size(), left_blanks, right_blanks);
Expand All @@ -57,7 +57,9 @@ Table2D::toString(const std::string& prefix) const

// The first column must align with the user desires
// All other columns should only use the previous lines space suffix
const std::string column_prefix = (col == 0) ? prefix : "";
std::string column_prefix = "";
if (col == 0)
column_prefix = prefix + '|';

// For the first row add the headers
const auto space_suffix = std::string(m_inter_entry_padding, ' ');
Expand Down
35 changes: 3 additions & 32 deletions src/runtime_src/core/tools/common/reports/ReportAiePartitions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ populate_aie_partition(const xrt_core::device* device)
boost::property_tree::ptree pt_entry;
pt_entry.put("pid", entry.pid);
pt_entry.put("context_id", entry.metadata.id);
pt_entry.put("status", entry.is_suspended ? "Idle" : "Active");
pt_entry.put("instr_bo_mem", entry.instruction_mem);
pt_entry.put("command_submissions", entry.command_submissions);
pt_entry.put("command_completions", entry.command_completions);
Expand Down Expand Up @@ -62,35 +63,6 @@ populate_aie_partition(const xrt_core::device* device)
return pt;
}

static std::string
calculate_col_utilization(const xrt_core::device* device, boost::property_tree::ptree &_pt)
{
auto total_device_cols = xrt_core::device_query_default<xrt_core::query::total_cols>(device, 0);
if (total_device_cols == 0)
return "N/A";

boost::property_tree::ptree empty_ptree;
uint64_t total_active_cols = 0;
const boost::property_tree::ptree pt_partitions = _pt.get_child("partitions", empty_ptree);
for (auto& pt_partition : pt_partitions) {
auto& partition = pt_partition.second;
const auto num_cols = partition.get<uint64_t>("num_cols");
for (const auto& pt_hw_context : partition.get_child("hw_contexts", empty_ptree)) {
const auto& hw_context = pt_hw_context.second;
// We consider a context and its columns active if there are more cmd submissions than completions.
if (hw_context.get<uint64_t>("command_submissions") > hw_context.get<uint64_t>("command_completions")) {
total_active_cols += num_cols;
break;
}
}
}
// If this check is true, at least two contexts were active on the same column at once.
if (total_active_cols > total_device_cols)
total_active_cols = total_device_cols;
double total_col_occupancy = ((static_cast<double>(total_active_cols) / total_device_cols) * 100);
return boost::str(boost::format("%.0f%%") % total_col_occupancy);
}

void
ReportAiePartitions::
getPropertyTreeInternal(const xrt_core::device* _pDevice,
Expand All @@ -109,7 +81,6 @@ getPropertyTree20202(const xrt_core::device* _pDevice,
boost::property_tree::ptree pt;
pt.put("description", "AIE Partition Information");
pt.add_child("partitions", populate_aie_partition(_pDevice));
pt.put("total_col_occupancy", calculate_col_utilization(_pDevice, pt));
_pt.add_child("aie_partitions", pt);
}

Expand All @@ -128,8 +99,6 @@ writeReport(const xrt_core::device* /*_pDevice*/,
return;
}

_output << boost::str(boost::format("Total Column Occupancy: %s\n") % _pt.get<std::string>("aie_partitions.total_col_occupancy"));

for (const auto& pt_partition : pt_partitions) {
const auto& partition = pt_partition.second;

Expand All @@ -145,6 +114,7 @@ writeReport(const xrt_core::device* /*_pDevice*/,
const std::vector<Table2D::HeaderData> table_headers = {
{"PID", Table2D::Justification::left},
{"Ctx ID", Table2D::Justification::left},
{"Status", Table2D::Justification::left},
{"Instr BO", Table2D::Justification::left},
{"Sub", Table2D::Justification::left},
{"Compl", Table2D::Justification::left},
Expand All @@ -165,6 +135,7 @@ writeReport(const xrt_core::device* /*_pDevice*/,
const std::vector<std::string> entry_data = {
hw_context.get<std::string>("pid"),
hw_context.get<std::string>("context_id"),
hw_context.get<std::string>("status"),
xrt_core::utils::unit_convert(hw_context.get<uint64_t>("instr_bo_mem")),
hw_context.get<std::string>("command_submissions"),
hw_context.get<std::string>("command_completions"),
Expand Down
Loading