ML timeline buffer needs to be 12KB aligned now #8585
Merged
+42
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 30, 2024 10:54
… Host Buffer gets overwriiten with excess record timer data. Signed-off-by: Ishita Ghosh <[email protected]>
Signed-off-by: Ishita Ghosh <[email protected]>
…ed as data does not sync well then. Always round up to next 12KB aligned size when adjusting. Signed-off-by: Ishita Ghosh <[email protected]>
jvillarre
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Each record timer entry now has 32 bit ID + 64bit AIE Timer(High+Low). So, the buffer should be 12KB aligned to avoid incorrect reads when buffer is overwritten with excess record timer data.
A fix was added earlier to use 192KB as the default host buffer size. This PR now adjusts the user specified buffer size to 12KB aligned.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
#8416 introduced the issue and it was discovered by DPU team
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Unit tests
Documentation impact (if any)