Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[65_8] Refactor: use locase and is_upper #1438

Merged
merged 1 commit into from
Dec 11, 2023
Merged

[65_8] Refactor: use locase and is_upper #1438

merged 1 commit into from
Dec 11, 2023

Conversation

da-liii
Copy link
Contributor

@da-liii da-liii commented Dec 11, 2023

No description provided.

@da-liii da-liii changed the title [65_8] Refactor: use locale and is_upper [65_8] Refactor: use locase and is_upper Dec 11, 2023
@jingkaimori
Copy link
Contributor

Can this patch works on non-english keyboard?

@da-liii
Copy link
Contributor Author

da-liii commented Dec 11, 2023

Can this patch works on non-english keyboard?

All usage of key here is guarded by key < 128

@da-liii da-liii merged commit e57294b into branch-1.2 Dec 11, 2023
7 checks passed
@da-liii da-liii deleted the da/65_8/refactor branch December 11, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@da-liii @jingkaimori