Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1_45] clean up for src/Graphics/Mathematics #1561

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Conversation

jingkaimori
Copy link
Contributor

Why you open this Pull Request?

clean up codebase, remove usage of ENABLE_TESTS

What work have you done in the current Pull Request?

remove miscellaneous inactive code inside src/Graphics/Mathematics.

  • remove unused ball and function class
  • fix an compilation error
  • rewrite test with QTest

@da-liii da-liii changed the title [1_45] clean up [1_45] clean up for src/Graphics/Mathematics Jan 15, 2024
Copy link
Contributor

@da-liii da-liii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da-liii da-liii merged commit 19c413c into branch-1.2 Jan 15, 2024
8 checks passed
@da-liii da-liii deleted the jk/1_45/math-cleanup branch January 15, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants