Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1_46] remove experimental style code #1562

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

jingkaimori
Copy link
Contributor

Why you open this Pull Request?

Clean up codebase. Experimental style mechanism can be activated by experimental option from xmake. When activated, a new mechanism to expanding macros into primitive is invoked, and expanded primitives is logged into cout. This expansion mechanism is outdated and has several bugs, so generated primitive tree is not rendered, therefore this part can be removed safely and smoothly.

What work have you done in the current Pull Request?

  • remove src/Style folder
  • remove usage of EXPERIMENTAL macro
  • remove corresponding xmake instructions

Copy link
Contributor

@da-liii da-liii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da-liii da-liii merged commit b40a277 into branch-1.2 Jan 15, 2024
8 checks passed
@da-liii da-liii deleted the jk/1_46/remove-exp-style branch January 15, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants