Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[80_8] Using OpenType glyph construct/assembly table #2120

Merged
merged 15 commits into from
Oct 29, 2024

Conversation

KeShih
Copy link
Contributor

@KeShih KeShih commented Sep 30, 2024

What?

Improved the typesetting of rubber character using the Opentype glyph assembly table, particularly in terms of brackets of different sizes.
In fact, this PR have already supported all variants in the Opentype assembly table, but since Texmacs itself may not provide such variants, we cannot directly use them. We can use some unconventional methods to make it appear, such as Asana Math providing the assembly for Unicode 2907. We can use <left-#2907-50> to render its 50 variant (don't care why "left").
image
image

Why?

For Opentype math fonts, many rubber characters, such as various braces, are not properly constructed.

How to test it?

Open devel/80_8.tmu.

Before:
image

After:
image

It can be seen that the first two Opentype fonts have been correctly improved, while the latter two have not changed because we used a hardcoded solution.

@KeShih KeShih reopened this Oct 21, 2024
@da-liii da-liii marked this pull request as ready for review October 28, 2024 16:27
@KeShih KeShih changed the title [80_8] Using OpenType glyph construct table [80_8] Using OpenType glyph construct/assembly table Oct 29, 2024
Copy link
Contributor

@da-liii da-liii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da-liii da-liii merged commit 4d6a517 into XmacsLabs:branch-1.2 Oct 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants