-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[80_8] Using OpenType glyph construct/assembly table #2120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeShih
force-pushed
the
glyph-construct
branch
from
October 21, 2024 10:17
cbccba7
to
e2d5c20
Compare
KeShih
force-pushed
the
glyph-construct
branch
from
October 26, 2024 09:36
07b8713
to
303c2b8
Compare
KeShih
force-pushed
the
glyph-construct
branch
from
October 28, 2024 14:30
095a865
to
d3985ca
Compare
KeShih
changed the title
[80_8] Using OpenType glyph construct table
[80_8] Using OpenType glyph construct/assembly table
Oct 29, 2024
da-liii
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improved the typesetting of rubber character using the Opentype glyph assembly table, particularly in terms of brackets of different sizes.
In fact, this PR have already supported all variants in the Opentype assembly table, but since Texmacs itself may not provide such variants, we cannot directly use them. We can use some unconventional methods to make it appear, such as Asana Math providing the assembly for Unicode 2907. We can use
<left-#2907-50>
to render its 50 variant (don't care why "left").Why?
For Opentype math fonts, many rubber characters, such as various braces, are not properly constructed.
How to test it?
Open
devel/80_8.tmu
.Before:
After:
It can be seen that the first two Opentype fonts have been correctly improved, while the latter two have not changed because we used a hardcoded solution.