-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notebooks using GPU & puzzle batching #35
Conversation
Reviewer's Guide by SourceryThis pull request focuses on updating the notebooks to fix broken links, refactoring the sampling logic to improve flexibility and performance, and updating test cases to align with these changes. Additionally, it includes the removal of obsolete notebook files and the addition of new feature links in the README. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Xmaster6y - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
Here's what I looked at during the review
- 🟡 General issues: 8 issues found
- 🔴 Security: 2 blocking issues
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Summary by Sourcery
This pull request introduces GPU support for running models in the notebooks, updates notebook URLs to use underscores, enhances puzzle evaluation metrics, refactors
Sampler
classes, and updates documentation and tests accordingly.Sampler
classes to removeuse_argmax
attribute from the base class and handle it in derived classes.Sampler
class structure and new batch size handling.