Merge pull request #1 from YaleUniversity/mods_for_v2.0.1

Mods for v3.0.0 (was Mods for v2.0.1)
YaleUniversity · Jul 6, 2017 · 37f3323 · 37f3323
2 parents 805c8f7 + 0cda58e
commit 37f3323
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/examples/get_computer_dn.rb b/examples/get_computer_dn.rb
@@ -26,4 +26,4 @@
 c = AdManagement::Client.new(conf).connect!
 
 ## Display a computer accounts DistinguishedName
-puts c.get(computer_cn + '$')
+puts c.get(computer_cn)
diff --git a/lib/ad_management/objects/computer.rb b/lib/ad_management/objects/computer.rb
@@ -5,10 +5,10 @@ module Objects
     module Computer
       ##
       # Gets the dn of a computer object
-      def get(sam_account_name)
-        raise AdManagement::ArgumentError, 'Required parameter sam_account_name not provided!' if sam_account_name.nil?
-        @logger.info("Getting DN of #{sam_account_name}")
-        dn = search(sam_account_name + '$').first&.dn || ''
+      def get(cn)
+        raise AdManagement::ArgumentError, 'Required parameter cn not provided!' if cn.nil?
+        @logger.info("Getting DN of #{cn}")
+        dn = search(cn + '$').first&.dn || ''
         dn
       end
 
@@ -39,7 +39,8 @@ def create(cn, ou, managed_by)
             objectClass: %w[computer organizationalPerson person top user],
             cn: cn,
             sAMAccountName: cn + '$',
-            managedBy: managed_by_dn
+            managedBy: managed_by_dn,
+            userAccountControl: '4096'
           }
         )
         return "CN=#{cn},#{ou}" if result

diff --git a/lib/ad_management/version.rb b/lib/ad_management/version.rb
@@ -1,3 +1,3 @@
 module AdManagement
-  VERSION = '2.0.0'.freeze
+  VERSION = '3.0.0'.freeze
 end