feat(exif): Enable EXIF Writing using FIMD_EXIF_RAW #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeImage keeps two separate copies of Exif Metadata in memory: - One is used/found in MDM_EXIF_MAIN and its extensions(e.g. MDM_EXIF_GPS). - Another one is used when files are actually written that support the EXIF Format. - In some cases you want to access, the raw data. - A good example of this is when using MetadataModel.DestroyModel to wipe EXIF data on an image that you wanted persisted if that file is exported again from FreeImage. - DestoryModel was also corrected to DestroyModel, this will result in a breaking change version but that's worth it! With this you can use the following to clear and persist that "clearing" of the exif data on a FreeImage image: ```cs ImageMetadata imageMetadata = new ImageMetadata(dib, true, true); var model = imageMetadata[FREE_IMAGE_MDMODEL.FIMD_EXIF_RAW]; model.DestroyModel(); ``` When you then write that subsequent image to a file, the file will not contain any EXIF data! This is based on: - https://sourceforge.net/p/freeimage/discussion/36111/thread/2d087f91/ where i discovered FIMD_EXIF_RAW - https://sourceforge.net/p/freeimage/discussion/36111/thread/8233f5bc/ where I learnt how you might use it. As this change doesn't touch the native library, you won't need to compile that again. This is a purely .NET change. -
|
While this is straight forward, I'm still wanting at least 1 team review from Geenz or Froox. Due to the nature of free-image being very complicated. |
Geenz
reviewed
May 9, 2024
| @@ -148,7 +148,7 @@ public bool RemoveTag(string key) | |||
| /// which will remove all tags of this model from the bitmap. | |||
| /// </summary> | |||
| /// <returns>Returns true on success, false on failure.</returns> | |||
| public bool DestoryModel() | |||
| public bool DestroyModel() | |||
There was a problem hiding this comment.
Especially when it tells a "destory"
|
Looks good to me. |
Geenz
approved these changes
May 9, 2024
|
Ok, I'll roll a new version thanks!, this unblocks some work im doing! |
|
More context now available here: Yellow-Dog-Man/Resonite-Issues#2015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeImage keeps two separate copies of Exif Metadata in memory:
With this you can use the following to clear and persist that "clearing" of the exif data on a FreeImage image:
When you then write that subsequent image to a file, the file will not contain any EXIF data!
This is based on:
As this change doesn't touch the native library, you won't need to compile that again. This is a purely .NET change. -