Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Tron logs for jobs using other services images #1001

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fixing Tron logs for jobs using other services images #1001

wants to merge 3 commits into from
+86 −1

Commits on Oct 17, 2024

  1. Refactor scribereader_test.py and scribereader.py 

    This commit refactors the scribereader_test.py and scribereader.py files. It introduces a new function, get_log_namespace, which retrieves the log namespace from a yelpsoa-configs configuration file. The function is used in the PaaSTALogs class in scribereader.py to set the namespace for logging. The commit also includes unit tests for the get_log_namespace function.

Closes TRON-2275
    @cuza
    cuza committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    52f84b3 View commit details
    Browse the repository at this point in the history

  2. update type annotations in scribereader.py

    @cuza
    cuza committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    0f015b9 View commit details
    Browse the repository at this point in the history

  3. Fix type annotation error in scribereader.py

    @cuza
    cuza committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e8e3c4d View commit details
    Browse the repository at this point in the history